fix: more instances of RML fetched namespace #196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@redmer thanks for this! Our developments crossed each other as in v1.5.1 we fixed this issue, together with (a part of) #197, see https://github.com/RMLio/yarrrml-parser/blob/development/lib/namespaces.js . Could you check which part of #197 still makes sense, so we can focus our next part? I'm closing this one since it got superseded. Thanks a lot for the PR though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After another CI fail where no TriplesMaps were found, I navigated through the code and saw that prefix.cc redefined
rml:.19aeab2 already fixed this in
bin/parser.js; but as I was usinglib/rml-generator.js, I created this PR to manually add the right rml namespace for all files wherenamespaces.rmlwas used.Fixes #195.